Prepare v1.2.5 release. #3086

Random-Liu · 2019-03-09T01:14:25Z

Please feel free to comment if you want to add anything or change anything.

Signed-off-by: Lantao Liu [email protected]

codecov-io · 2019-03-09T02:02:48Z

Codecov Report

Merging #3086 into release/1.2 will decrease coverage by 2.9%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2    #3086      +/-   ##
===============================================
- Coverage        43.75%   40.84%   -2.91%     
===============================================
  Files              101       70      -31     
  Lines            10736     9395    -1341     
===============================================
- Hits              4697     3837     -860     
+ Misses            5309     5001     -308     
+ Partials           730      557     -173

Flag	Coverage Δ
#linux	`?`
#windows	`40.84% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
snapshots/native/native.go	`1.78% <0%> (-41.52%)`	⬇️
archive/tar.go	`16.99% <0%> (-26.8%)`	⬇️
metadata/snapshot.go	`21.53% <0%> (-24.28%)`	⬇️
content/local/writer.go	`56.86% <0%> (-0.99%)`	⬇️
gc/scheduler/scheduler.go	`66.34% <0%> (-0.97%)`	⬇️
oci/spec_opts.go	`20.49% <0%> (-0.28%)`	⬇️
mount/temp_unix.go
sys/reaper_linux.go
services/server/server_linux.go
sys/env.go
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075e1ed...6878e2b. Read the comment docs.

fuweid · 2019-03-11T09:11:02Z

Hi @Random-Liu , I want to cherry-pick #2876 into release 1.2. 😄

see #3087

fuweid · 2019-03-11T14:59:40Z

and are we need the runC CVE patch for this release?

see #3082

cc @thaJeztah

estesp · 2019-03-11T16:42:55Z

release notes need an update for #3087 and #3082

Random-Liu · 2019-03-11T17:41:07Z

are we need the runC CVE patch for this release?

Good, we need the runc fix as well. Happy that it gets in!

Random-Liu · 2019-03-11T17:56:53Z

@fuweid @estesp Done.

fuweid

LGTM!

The failed CI doesn't relate to this change. @Random-Liu could you mind to rerun it again? Thanks

Random-Liu · 2019-03-12T07:38:04Z

@fuweid Triggered the rerun.

Random-Liu · 2019-03-12T08:40:28Z

One more fix needed: containerd/cri#1085

Will get it in today.

estesp

LGTM

dmcgowan · 2019-03-12T18:06:57Z

releases/v1.2.5.toml

existent, on line 29 too

dmcgowan · 2019-03-12T18:09:53Z

releases/v1.2.5.toml

* support for GC references to content from snapshot and container objects. https://github.com/containerd/containerd/pull/3080

dmcgowan · 2019-03-12T18:19:46Z

Also #3090 for generated release notes. Putting my test generation here https://gist.github.com/dmcgowan/93905b44c5888d92440e9efac93f7659

crosbymichael · 2019-03-12T21:22:00Z

LGTM

Random-Liu · 2019-03-13T00:03:56Z

I think everything is ready. :)

estesp · 2019-03-13T00:25:35Z

I think we usually include the version/version.go bump in the "prepare" PR; so can put repush with that and then I think we're ready to merge

Random-Liu · 2019-03-13T00:44:55Z

I think we usually include the version/version.go bump in the "prepare" PR; so can put repush with that and then I think we're ready to merge

Oops... Missed that. Will do! And good catch.

Signed-off-by: Lantao Liu <[email protected]>

Random-Liu · 2019-03-13T00:46:26Z

@estesp Done. :)

fuweid · 2019-03-13T00:56:17Z

--- FAIL: TestContentClient/CommitErrorState (3.69s)
        testsuite.go:101: Cleanup failed: unknown
            github.com/containerd/containerd/errdefs.init
            	C:/gopath/src/github.com/containerd/containerd/errdefs/errors.go:39
            github.com/containerd/containerd/content.init
            	<autogenerated>:1
            github.com/containerd/containerd.init
            	<autogenerated>:1
            main.init
            	<autogenerated>:1
            runtime.main
            	C:/go/src/runtime/proc.go:189
            runtime.goexit
            	C:/go/src/runtime/asm_amd64.s:1333
            remove C:\Program Files\containerd\root-test\io.containerd.content.v1.content\ingest\9101c5f249b4cb38a50dddda86a787c09f31099573c87c525fc50774ac21d05d\.tmp-updatedat366893897: The process cannot access the file because it is being used by another process.
            github.com/containerd/containerd/errdefs.FromGRPC
            	C:/gopath/src/github.com/containerd/containerd/errdefs/grpc.go:98
            github.com/containerd/containerd/content/proxy.(*proxyContentStore).Abort
            	C:/gopath/src/github.com/containerd/containerd/content/proxy/content_store.go:187
            github.com/containerd/containerd.newContentStore.func2
            	C:/gopath/src/github.com/containerd/containerd/content_test.go:60
            github.com/containerd/containerd/content/testsuite.makeTest.func1.1
            	C:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:100
            github.com/containerd/containerd/content/testsuite.makeTest.func1
            	C:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:121
            testing.tRunner
            	C:/go/src/testing/testing.go:827
            runtime.goexit
            	C:/go/src/runtime/asm_amd64.s:1333
            failed to abort c1-commiterror-state
            github.com/containerd/containerd.newContentStore.func2
            	C:/gopath/src/github.com/containerd/containerd/content_test.go:61
            github.com/containerd/containerd/content/testsuite.makeTest.func1.1
            	C:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:100
            github.com/containerd/containerd/content/testsuite.makeTest.func1
            	C:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:121
            testing.tRunner
            	C:/go/src/testing/testing.go:827
            runtime.goexit
            	C:/go/src/runtime/asm_amd64.s:1333

flaky case in windows 😞 need to rerun it again.

dmcgowan · 2019-03-13T00:58:55Z

Re-kicked it, and LGTM, updated https://gist.github.com/dmcgowan/93905b44c5888d92440e9efac93f7659

AkihiroSuda approved these changes Mar 9, 2019

View reviewed changes

Random-Liu force-pushed the prepare-release-1-2-5 branch from dc02b79 to 8f8ece7 Compare March 11, 2019 17:56

Random-Liu force-pushed the prepare-release-1-2-5 branch 3 times, most recently from 6009a37 to 2588620 Compare March 12, 2019 00:11

fuweid reviewed Mar 12, 2019

View reviewed changes

Random-Liu mentioned this pull request Mar 12, 2019

Fix /etc/hostname backward compatibility issue for in-place upgrade. containerd/cri#1085

Merged

fuweid approved these changes Mar 12, 2019

View reviewed changes

estesp approved these changes Mar 12, 2019

View reviewed changes

dmcgowan reviewed Mar 12, 2019

View reviewed changes

Random-Liu force-pushed the prepare-release-1-2-5 branch from 2588620 to 92da880 Compare March 12, 2019 21:34

Prepare v1.2.5 release.

6878e2b

Signed-off-by: Lantao Liu <[email protected]>

Random-Liu force-pushed the prepare-release-1-2-5 branch from 92da880 to 6878e2b Compare March 13, 2019 00:46

estesp merged commit bb71b10 into containerd:release/1.2 Mar 13, 2019

Prepare v1.2.5 release. #3086

Prepare v1.2.5 release. #3086

Uh oh!

Conversation

Random-Liu commented Mar 9, 2019

Uh oh!

codecov-io commented Mar 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fuweid commented Mar 11, 2019

Uh oh!

fuweid commented Mar 11, 2019

Uh oh!

estesp commented Mar 11, 2019

Uh oh!

Random-Liu commented Mar 11, 2019

Uh oh!

Random-Liu commented Mar 11, 2019

Uh oh!

fuweid left a comment

Choose a reason for hiding this comment

Uh oh!

Random-Liu commented Mar 12, 2019

Uh oh!

Random-Liu commented Mar 12, 2019

Uh oh!

estesp left a comment

Choose a reason for hiding this comment

Uh oh!

dmcgowan Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

Random-Liu Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

dmcgowan Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

Random-Liu Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

dmcgowan commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crosbymichael commented Mar 12, 2019

Uh oh!

Random-Liu commented Mar 13, 2019

Uh oh!

estesp commented Mar 13, 2019

Uh oh!

Random-Liu commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Random-Liu commented Mar 13, 2019

Uh oh!

fuweid commented Mar 13, 2019

Uh oh!

dmcgowan commented Mar 13, 2019

Uh oh!

Uh oh!

codecov-io commented Mar 9, 2019 •

edited

Loading

dmcgowan commented Mar 12, 2019 •

edited

Loading

Random-Liu commented Mar 13, 2019 •

edited

Loading