[release/1.2] Cherry-pick update to gRPC 1.23.0 #3586
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3586 +/- ##
============================================
Coverage 44.09% 44.09%
============================================
Files 100 100
Lines 10790 10790
============================================
Hits 4758 4758
Misses 5293 5293
Partials 739 739
Continue to review full report at Codecov.
|
|
Might want to wait for @stevvooe to have a look; there's doubt if my fix in ttrpc is correct containerd/ttrpc#46 (comment) |
|
I removed my LGTM and I wanna test this more. I ran into a ttrpc mismatch when updating containerd and i wanna see if old shims can talk to a new containerd with the ttrpc change. Also, because of this patch. I think we should test the grpc bump a little longer. GRPC changes can be risky and since the contaienrd socket is over a unix socket owned by root, we don't have a huge risk or DoS attack. I guess CRI is a different story. |
|
Would it be possible to test these scenarios in CI? (mixed version shims/clients/dockerd-versions)?(happy to help) |
Signed-off-by: Michael Crosby <[email protected]>
Includes partial cherry-pick of prior master PR: "bump google.golang.org/grpc v1.20.1" Code changes from master cherry-picked to release/1.2 for the commit 2ed8e60. The vendoring is taken from the recent CVE release of gRPC to 1.23.0 in commit eb7a6bf. Signed-off-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Phil Estes <[email protected]>
|
Just FYI: this PR has been updated with the new ttrpc vendor merged in master in #3592 |
|
LGTM |
Includes partial cherry-pick of prior master PR #3192: "bump google.golang.org/grpc v1.20.1"
Required core code changes from master cherry-picked to
release/1.2from the commit2ed8e60. The vendoring is taken from the recent CVE release of gRPC to 1.23.0 in commit
eb7a6bf (PR #3581).
Signed-off-by: Sebastiaan van Stijn [email protected]
Signed-off-by: Phil Estes [email protected]