[release/1.2 backport] Compute manifest metadata when not provided. #3591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was requested by @artch to help compatibility with the GitHub Package Registry #3245 (comment) /cc @Phanatic |
This was referenced Aug 28, 2019
Merged
|
Looks like additional changes are needed to make this work; |
|
Need to backport #2751 |
This reverts commit 1af8e6e. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Charles Kenney <[email protected]> (cherry picked from commit 068880f) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Fixes containerd#2870 Signed-off-by: Eric Lin <[email protected]> (cherry picked from commit 2db0c6c) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Currently the user agent is only being used on the initial resolve request, then switching to the default user agent. This ensures the correct user agent is always used. There is a larger fix in progress which does this is a cleaner way, but the scope of this change is fixing the user agent issue. Signed-off-by: Derek McGowan <[email protected]> (cherry picked from commit bb00872) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This closes containerd#3238 Signed-off-by: msg555 <[email protected]> (cherry picked from commit ee902af) Signed-off-by: Sebastiaan van Stijn <[email protected]>
0a49e64 to
0d6d883
Compare
|
OK; I had a look what is needed to get a clean backport, but that would include #3335, which (I think) is a feature.
I'll leave it to the maintainers to decide if this is ok, or if I need to spend some time to adapt the backport to work |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3591 +/- ##
===============================================
- Coverage 44.09% 44.03% -0.07%
===============================================
Files 100 100
Lines 10790 10837 +47
===============================================
+ Hits 4758 4772 +14
- Misses 5293 5325 +32
- Partials 739 740 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3245 for the 1.2 branch
Adds a fallback to manually compute the manifest digest when it is not presented as the Docker-Content-Digest header by the registry server. This is to address #3238.
closes #3238
addresses parts of #3291