Use default UNIX env when image has no environment #3599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phil Estes <[email protected]>
8dfaa0e to
bc692cc
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3599 +/- ##
=========================================
+ Coverage 42.27% 42.4% +0.12%
=========================================
Files 126 126
Lines 13887 13894 +7
=========================================
+ Hits 5871 5892 +21
+ Misses 7130 7116 -14
Partials 886 886
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3599 +/- ##
=========================================
+ Coverage 42.27% 42.4% +0.12%
=========================================
Files 126 126
Lines 13887 13894 +7
=========================================
+ Hits 5871 5892 +21
+ Misses 7130 7116 -14
Partials 886 886
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3597
Only open question IMO is whether we want to investigate whether a config has a
$PATHset versus simply checking for a nil/empty environment in the image config.Signed-off-by: Phil Estes [email protected]