Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

crosbymichael
Copy link
Member

Includes fix for user namespaces and NOTIFY_SOCKET.

Signed-off-by: Michael Crosby [email protected]

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Member

estesp commented Sep 11, 2019

Looks like you have to run vndr since more changes came in since the last update in release/1.2:

 M vendor/github.com/containerd/go-runc/README.md
 M vendor/github.com/containerd/go-runc/runc.go

Includes fix for user namespaces and NOTIFY_SOCKET.

Signed-off-by: Michael Crosby <[email protected]>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #3640 into release/1.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.2    #3640   +/-   ##
============================================
  Coverage        44.19%   44.19%           
============================================
  Files              100      100           
  Lines            10847    10847           
============================================
  Hits              4794     4794           
  Misses            5313     5313           
  Partials           740      740
Flag Coverage Δ
#linux 47.87% <ø> (ø) ⬆️
#windows 41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50db0a...5d46475. Read the comment docs.

@estesp estesp merged commit 710fca1 into containerd:release/1.2 Sep 11, 2019
@crosbymichael crosbymichael deleted the 1.2-go-runc branch September 11, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants