Rework git and application processes #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58b7483 to
34e7f33
Compare
This commit reworks the way fetchit gets changes and applies them. The point of this commit is to simplify the fetchit process in order to make it more clear and extensible. This commit reduces the previous process for applying the initial state and following changes to just getting the current state, getting the latest state, then applying a method to the difference of those two states. In the case of an initial apply, the current state is empty. Otherwise the current state is marked by a git tag on the commit corresponding to the current state. This commit also fixes a bug where the scheduler was only scheduling the first method in the queue to run immediately rather than all of them. This commit also removes all calls to the update method of the fetchit config, since fetchit is using pointers to manipulate target objects instead of making copies of them. This commit also adds trailing slashes to all target paths specifying direcotries, in the configs in the examples directory. Signed-off-by: Joseph Sawaya <[email protected]>
34e7f33 to
0ba44b7
Compare
Collaborator
|
This PR is looking great, it's a huge improvement. /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks the way fetchit gets changes
and applies them.
The point of this commit is to simplify the fetchit
process in order to make it more clear and extensible.
This commit reduces the previous process for applying
the initial state and following changes to just getting
the current state, getting the latest state, then applying
a method to the difference of those two states. In the case
of an initial apply, the current state is empty. Otherwise
the current state is marked by a git tag on the commit
corresponding to the current state.
This commit also fixes a bug where the scheduler was only
scheduling the first method in the queue to run immediately
rather than all of them.
This commit also removes all calls to the update method
of the fetchit config, since fetchit is using pointers to
manipulate target objects instead of making copies of them.
Signed-off-by: Joseph Sawaya [email protected]