[WIP] Activate ORM by default #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description ----------- Removes storing the dev access key in the `install-web-dir` command, where it actually never should have been. In the previous implementation the access key was stored multiple times (in manager config and in `.env` file). It also meant that removing the key through the command would re-add it the next time the command is run without arguments (because the manager config still exists). This is now all fixes by simply updating the `.env` file through the API. Commits ------- 949083a Remove access key handling from install-web-dir command 486ffdf Added command to set and remove the dev access key febf86a Use dependency injection for api commands 0c14075 Revert an unrelated change. ae381e4 Use addArgument() instead of setDefinition(). e5ce2ce Revert "Revert an unrelated change." 14c921b Use set and remove commands for access key in Contao API 27ac0e7 Added a command to get the access-key 2f136b7 Re-added the PluginLoader argument fc1b599 Fix the coding style and revert unrelated changes (security.yml).
7 tasks
4a69d0b to
a702c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates ORM in a Contao Managed Edition.
Currently blocked by contao/core-bundle#685 and follow-up PR for persistent remember me token, as we must have at least one entity in the application or Doctrine Schema (and therefore the install tool) will fail if ORM is enabled without entity.
/cc @leofeyer @bytehead