[Github CI] Reenable MSVC compiler testing#11
Merged
Conversation
Signed-off-by: Christian Parpart <[email protected]>
0861162 to
83b554a
Compare
Yaraslaut
reviewed
Nov 5, 2024
Member
Yaraslaut
left a comment
There was a problem hiding this comment.
This is good that we test now on all platforms, i will try to fix the issue with the enum name
Member
Author
Oh thank you. I'm apologizing ahead of time, because I fear that I broke it :) |
bce2247 to
3e7a41c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Yaraslaut the current way of finding Catch2 on windows produced a linker error. This is why I disabled windows CI back then. It should always favor system packages if present anyways, so I've tweaked that bit a bit.
But now I realized, that the tests where breaking on MSVC. I hope to find some time to check on why soon, too.