Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PHP 7.1, Travis stages, updated dependencies, phpstan#6

Merged
f3l1x merged 1 commit into
masterfrom
php7.1
Jun 13, 2018
Merged

PHP 7.1, Travis stages, updated dependencies, phpstan#6
f3l1x merged 1 commit into
masterfrom
php7.1

Conversation

@mabar

@mabar mabar commented Jun 12, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@mabar mabar requested a review from f3l1x June 12, 2018 09:49
@mabar mabar changed the title PHP 7.1, Travis stages, updated dependencies PHP 7.1, Travis stages, updated dependencies, phpstan Jun 12, 2018
Comment thread src/PluggableConfigurator.php Outdated
foreach ($this->plugins as $plugin) {
// Skip different plugin
if (!($plugin instanceof $class)) continue;
if (!($plugin instanceof $class)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oneline please

Comment thread src/ExtraConfigurator.php Outdated
} else if (strtolower($value) === 'false' || $value === '0') {
$debug = FALSE;
$debug = true;
} else {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wut?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phpstorm did it without warning. I don't understand why, my configuration should only convert else if to elseif

Comment thread src/ExtraConfigurator.php Outdated
{
$map = function (&$array, array $keys, $value) use (&$map) {
if (count($keys) <= 0) return $value;
if (count($keys) <= 0) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oneline please

Comment thread src/ExtraConfigurator.php Outdated
// Try to load file
$content = @file_get_contents($fileName ?: $appDir . '/../.debug');
if ($content === FALSE) return;
if ($content === false) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oneline please

Comment thread src/ExtraConfigurator.php Outdated
$appDir = $this->parameters['appDir'] ? $this->parameters['appDir'] : NULL;
if (!$fileName && !$appDir) return;
$appDir = $this->parameters['appDir'] ?? null;
if ($fileName === null && $appDir === null) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oneline please

Comment thread .editorconfig
trim_trailing_whitespace = true
indent_style = tab
indent_size = 4
indent_size = tab

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make exception for markdown, it cannot be tabbed (due to Github red blackground)

@f3l1x f3l1x merged commit 657fa6d into master Jun 13, 2018
@f3l1x f3l1x deleted the php7.1 branch June 13, 2018 13:17
@f3l1x f3l1x added this to the v0.3 milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants