Fails to parse when body includes something that looks like a scope with new line#48
Open
Otard95 wants to merge 3 commits intoconventional-commits:mainfrom
Open
Fails to parse when body includes something that looks like a scope with new line#48Otard95 wants to merge 3 commits intoconventional-commits:mainfrom
Otard95 wants to merge 3 commits intoconventional-commits:mainfrom
Conversation
wesleytodd
approved these changes
May 19, 2025
wesleytodd
reviewed
May 19, 2025
maybe removing the whitespace here will kick off the CI.
wesleytodd
requested changes
Jan 20, 2026
Member
wesleytodd
left a comment
There was a problem hiding this comment.
Changing to request changes since this was failing in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally came across this when release-please didn't pick up one of our commits. Eventually I tracked it down to this package. I'm creating a PR, mostly to provide the failing test showing the issue. I minimized the test as much as possible, here's a snippet of the original text from the commit that failed to parse, if that's helpful:
The code block is a result of the text in this PR apollographql/federation#2818 ending up in one of our Renovate PR's and subsequently commit body.