Added method getShortContentAttribute to Post Model#495
Open
rodrigocalilo wants to merge 2 commits intocorcel:3.0from
Open
Added method getShortContentAttribute to Post Model#495rodrigocalilo wants to merge 2 commits intocorcel:3.0from
rodrigocalilo wants to merge 2 commits intocorcel:3.0from
Conversation
jgrossi
reviewed
Jan 27, 2020
Member
jgrossi
left a comment
There was a problem hiding this comment.
thanks man! added a few comments I'd like to discuss first before merging. thanks for the hard work 💪
jgrossi
requested changes
Jul 28, 2020
| /** | ||
| * @var int | ||
| */ | ||
| protected $characters = 400; |
Member
There was a problem hiding this comment.
make this a constant please
private const SHORT_CONTENT_CHAR_LIMIT = 400;| /** | ||
| * @return string | ||
| */ | ||
| public function getShortContentAttribute() |
Member
There was a problem hiding this comment.
get you please add a test case in PostTest class to support this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method returns the first 400 characters of the main content.