Loading Only Metas that were asked for#544
Loading Only Metas that were asked for#544Stevemoretz wants to merge 2 commits intocorcel:5.0from Stevemoretz:5.0
Conversation
|
I don't understand what could possibly go wrong I changed one line of code only. |
|
Hey! It seems the code style is not according to PSR2 |
|
Hey.
Here's the code.Could you be more specific? |
As per PSR-2
You've got a mix of spaces and tabs in your PR |
|
Oh cool thanks for clarification. My solution does make a lot of queries. I did try caching on both and the results are still slow. So I switched to other solutions like using with and with where condition to only get the metas that we need. With only makes one query and it's the best for performance reasons also can be used on many rows and still so fast. |
As I saw a problem in #543 I went and fixed it myself.