(change): concrete to abstract implementation#565
Merged
jgrossi merged 1 commit intocorcel:5.0from Sep 30, 2021
edwinsiebel:feat/use-application-contract
Merged
(change): concrete to abstract implementation#565jgrossi merged 1 commit intocorcel:5.0from edwinsiebel:feat/use-application-contract
jgrossi merged 1 commit intocorcel:5.0from
edwinsiebel:feat/use-application-contract
Conversation
jgrossi
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are using an concreate implementation of
Illuminate\Foundation\Application, while using the contract/interfaceIlluminate\Contracts\Foundation\Applicationallows for less rigid fixation, while still have the desired usage.We are using a fork of
Applicationwith the interface; in our case,Corcel::isLaravel()returns false because we're not usingIlluminate\Foundation\Application. However, with this PR, Corcel still works, and everybody who implements theApplicationinterface still can enjoy using Corcel.Should also be propagated to the older version of Corcel of course. If this will be merged, I can also make PR's for older version of Corcel.