[5.0] Remove missing phpass in favour of Laravel support hash#576
Open
TheoKouzelis wants to merge 2 commits intocorcel:5.0from
Open
[5.0] Remove missing phpass in favour of Laravel support hash#576TheoKouzelis wants to merge 2 commits intocorcel:5.0from
TheoKouzelis wants to merge 2 commits intocorcel:5.0from
Conversation
Phpass has been deleted. But upon investigating the package, it seems it's main purpose is to support strong hasing in php versions less than 5.5 https://www.openwall.com/phpass/. Since this package requires php 7.3. I don't think the dependency is required.
Author
|
Thinking about it, this will probably invalidate existing hashes stored in databases. |
Member
|
thanks for the PR and good catch. it seems the fact that it will invalidate existing hashes in DB might be a blocker tbh, but nothing we can't investigate and check if that will happen actually. if you can check I'd appreciate it. I'm gonna try to do the same ASAP |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phpass has been deleted. But upon investigating the package, it seems it's main purpose is to support strong hasing in php versions less than 5.5 https://www.openwall.com/phpass/. Since this package requires php 7.3. I don't think the dependency is required.