Thanks to visit codestin.com
Credit goes to github.com

Skip to content

First experimental implementation of ESMTP, HELO fallback and various improvements #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

First experimental implementation of ESMTP, HELO fallback and various improvements #11

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
34dbda4
simplify SSL config flag semantics, default is having SSL disabled un…
Oct 2, 2012
6574304
simplify read_remote logic and prevent infinite loops due to pos == l…
Oct 2, 2012
0ead6c3
rework yet again read_remote to be more secure, add HELO fallback and…
Oct 2, 2012
f22e7c5
add VERBOSE feature to debug network communication
Oct 2, 2012
aab5fbc
various bugfixes to VERBOSE logging and ESMTP parsing
Oct 2, 2012
d508bdb
fix buggy boolean guard
Oct 2, 2012
31fb2f4
fix ESMTP parsing
Oct 2, 2012
e5e6bc9
deliver_host simplify and make mail read loop more reliable
Oct 2, 2012
f5cc3fa
add VERBOSE option warning to config file
Oct 2, 2012
e8c66f2
Improve configuration file routines and port parsing
Oct 3, 2012
2fca723
Fix some issues with format and simplify a condition
Oct 3, 2012
7a19086
Make config file parsing more solid
Oct 3, 2012
76e0821
Improve HELO fallback and ESMTP capabilities refresh
Oct 3, 2012
c917cec
Drop entirely the no login fallback
Oct 3, 2012
bf5941f
Improve message on I/O error
Oct 3, 2012
005a007
Replace SECURETRANS with the more specific USESSL (probably SECURETRA…
Oct 3, 2012
1ae3e6b
First implementation of the PLAIN authentication method
Oct 3, 2012
460cc2d
More read_remote improvements, to error handling and parsing
Oct 3, 2012
1148a3d
Minor style fix
Oct 3, 2012
06621be
Update man page, minor style fix in config file.
Oct 3, 2012
c7e813d
Fix typo in man page.
Oct 3, 2012
b7977a8
Fix error message
Oct 3, 2012
c899ca3
Avoid mixed declaration and code.
Oct 3, 2012
faca752
Make connection structure to avoid modifying global data
Oct 3, 2012
afe9ead
Use memset() to 0 rather than the deprecated bzero()
Oct 3, 2012
138ea03
Try a better guess in the unlikely event that _SC_OPEN_MAX is unavail…
Oct 3, 2012
d380e95
Make local mail delivery function check for read errors.
Oct 3, 2012
1fcb993
Fix config file entry parsing
Oct 3, 2012
5591c0f
Revert "Fix config file entry parsing"
Oct 3, 2012
dc4f1a7
Fix man page entries.
Oct 3, 2012
87405fe
Simplify logging messages.
Oct 3, 2012
58109b0
Make PLAIN authentication work
Oct 3, 2012
ef4681b
Some minor fixes
Oct 3, 2012
8709011
Consistently replace bcopy() and bzero() with memcpy() and memset()
Oct 3, 2012
8761545
Clear file error flag
Oct 4, 2012
4752047
Check for I/O errors even on mail bounces
Oct 4, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix error message 
errno could be zero leading to a confusing message like:
SMTP login failed: success
  • Loading branch information
micia committed Oct 3, 2012
commit b7977a86cede6ded4d7370d28ebd5f2f9eb0d610
2 changes: 1 addition & 1 deletion net.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ deliver_to_host(struct qitem *it, struct mx_hostentry *host)
error = smtp_login(fd, a->login, a->password);
if (error) {
syslog(LOG_ERR, "remote delivery failed:"
" SMTP login failed: %m");
" SMTP login failed");
snprintf(errmsg, sizeof(errmsg), "SMTP login to %s failed", host->host);
goto out;
}
Expand Down