ci: cleanup; drop running COSA as UID 0#1046
Conversation
|
This is mostly a test to see if things pass. Let's see |
There was a problem hiding this comment.
Code Review
This pull request introduces several cleanups to the Jenkins CI pipeline. The most significant change is the removal of runAsUser: 0, which is a good security practice as it avoids running the container as root. The PR also removes an obsolete FIXME comment and streamlines cosa commands by removing a cosa fetch call (presumably redundant) and combining two cosa osbuild commands into a single one. Overall, these changes improve the maintainability, security, and efficiency of the CI script.
|
Thanks for looking at this! We have the same issue over in ostree. The next failure looks like it's because we're trying to install bootupd inside the cosa container. But I think we should now always use bootupd from the target system, so we could probably drop that? Or it would likely work to just add a |
This should have been dropped in b20cd82. Signed-off-by: Colin Walters <[email protected]>
This can be done in one shot now so let's do that to save some small amount of time. Signed-off-by: Colin Walters <[email protected]>
As part of moving to building via container (i.e. podman build) [1] `cosa fetch` became obsolete. [1] coreos/fedora-coreos-tracker#1969 Signed-off-by: Colin Walters <[email protected]>
This shouldn't be necessary. Let's see if tests pass. Signed-off-by: Colin Walters <[email protected]>
3d3fdda to
abb606b
Compare
Looks the issue happened only when running COSA as UID 0, also have the same issue in coreos-installer (see coreos/coreos-installer#1715) |
|
Thanks @cgwalters for the fixup |
No description provided.