grubconfigs: ensure bootuuid.cfg and grubenv with mode 0600#1063
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances security by ensuring that bootuuid.cfg and grubenv have file permissions set to 0600. The changes involve using a shared constant for the file mode when creating bootuuid.cfg and adding a new function to enforce the permissions on grubenv. The implementation is correct and includes a test to verify the new behavior. I have one suggestion to simplify the code in the new function.
23632f7 to
1880664
Compare
cgwalters
approved these changes
Feb 10, 2026
cgwalters
left a comment
Member
There was a problem hiding this comment.
Looks sane, but we probably want to also apply this fixup automatically on upgrades?
Contributor
Author
Good catch, will fix on upgrades later. |
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Feb 12, 2026
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Feb 12, 2026
HuijingHei
added a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1058