bios/efi: always use fsfreeze_thaw_cycle#970
Conversation
This is required when we use XFS, but it doesn't hurt to always use fsfreeze_thaw_cycle.
|
Hi @champtar. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Code Review
This pull request replaces syncfs() calls with fsfreeze_thaw_cycle() to ensure filesystem journals are properly flushed, which is particularly important for XFS. This change improves correctness and robustness by handling errors that were previously ignored. The review suggests simplifying the new calls by passing directory handles directly, avoiding unnecessary open_file calls.
|
/ok-to-test |
|
Thank you for the working, refer to |
This is required when we use XFS, but it doesn't hurt to always use fsfreeze_thaw_cycle.