efi: Do not update EFI variables if read only or empty#998
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a check to prevent updating EFI variables under certain conditions, which is a valuable improvement. However, the implementation has a couple of issues. There's a logic error in how an empty directory is checked, which could mask I/O errors. More critically, the new logic for conditionally updating firmware variables now silently ignores errors, which is a significant regression from the previous behavior. I've provided suggestions to address both of these points.
8fd208a to
73c2bbe
Compare
Contributor
Author
|
Hold on, need to fix the CI error. |
970489d to
6eb1c20
Compare
cgwalters
reviewed
Sep 6, 2025
2700233 to
fb3c830
Compare
travier
reviewed
Sep 8, 2025
travier
reviewed
Sep 8, 2025
8e0645b to
ac84d76
Compare
ac84d76 to
c687fd4
Compare
Contributor
Author
|
Update info to make it shorter, ready to review, thank you! |
travier
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #972