Add message tests #136
Merged
Add message tests #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- step 1 of adding testing to the tutorial Signed-off-by: Marko Baricevic <[email protected]>
okwme
reviewed
Sep 9, 2019
| func TestMsgSetName(t *testing.T) { | ||
| name := "maTurtle" | ||
| value := "1" | ||
| acc := sdk.AccAddress([]byte("me")) |
There was a problem hiding this comment.
not clear to me what's going on here. If you instantiate an address using an arbitrary byte string is that used as the private key?
There was a problem hiding this comment.
this is just creating a dummy account for testing. there is no need fo the priv key here, once we do simulaiton tests we will need to integrate something with priv key i believe
There was a problem hiding this comment.
i think its ok not to use valid addresses here since the test is focused on the nameservice message
okwme
approved these changes
Sep 9, 2019
hschoenburg
approved these changes
Sep 9, 2019
a825886 to
ccd8b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #13
Signed-off-by: Marko Baricevic [email protected]