Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Easy installation of coturn on AWS #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eakraly merged 2 commits into from
Nov 18, 2024
Merged

Easy installation of coturn on AWS #1581

eakraly merged 2 commits into from
Nov 18, 2024

Conversation

@hariprasadt
Copy link
Contributor

@hariprasadt hariprasadt commented Oct 4, 2024

@hariprasadt hariprasadt mentioned this pull request Oct 4, 2024
Open
kumar-himans
kumar-himans approved these changes Oct 4, 2024
View reviewed changes
Copy link

@kumar-himans kumar-himans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script for installation of coturn server on AWS EC2 instance.

mohanss08
mohanss08 approved these changes Oct 4, 2024
View reviewed changes
Copy link

@mohanss08 mohanss08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok changes are fine.

ekambaramv
ekambaramv approved these changes Oct 4, 2024
View reviewed changes
Copy link

@ekambaramv ekambaramv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looks good

@eakraly
Copy link
Collaborator

eakraly commented Oct 4, 2024

Hi @hariprasadt !
Any reason you are not updating the script to use latest version instead of older 4.5.2?
Maybe you can make 4.5.2 as an option while last version will be installed by default?

eakraly
eakraly reviewed Oct 4, 2024
View reviewed changes
eakraly
eakraly reviewed Oct 4, 2024
View reviewed changes
senthil2921
senthil2921 approved these changes Oct 6, 2024
View reviewed changes
Copy link

@senthil2921 senthil2921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is highly useful for automating the deployment of Coturn in an AWS EC2 environment.

@hariprasadt
Copy link
Contributor Author

hariprasadt commented Oct 9, 2024

Hi @hariprasadt ! Any reason you are not updating the script to use latest version instead of older 4.5.2? Maybe you can make 4.5.2 as an option while last version will be installed by default?

According to https://coturn.net/turnserver/, only 4.5.2 is the latest version. But users can change the script to use any other version at any time.

@hariprasadt hariprasadt force-pushed the setup_script_aws_ec2 branch from f03dbdb to 14ba6cc Compare October 9, 2024 06:24
@hariprasadt
Copy link
Contributor Author

hariprasadt commented Oct 9, 2024

UDPATED THE CODE WITH ALL REVIEW COMMENTS

@hariprasadt
Copy link
Contributor Author

hariprasadt commented Oct 14, 2024

@eakraly Can you pls merge this PR? I will raise another PR for Azure Cloud after this PR gets merged. Thank you.

eakraly
eakraly reviewed Oct 17, 2024
View reviewed changes
@hariprasadt
Copy link
Contributor Author

hariprasadt commented Oct 18, 2024 •
edited
Loading

@eakraly

  1. Script is now parameterized. We can pass pass coturn version as an argument. If not provided, then it considers 4.6.2 as default version.
  2. Verified this script on AWS EC2 instance also.

@eakraly eakraly merged commit e5ffe6e into coturn:master Nov 18, 2024
@chenrui333 chenrui333 mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eakraly eakraly eakraly left review comments

+4 more reviewers

@mohanss08 mohanss08 mohanss08 approved these changes

@ekambaramv ekambaramv ekambaramv approved these changes

@senthil2921 senthil2921 senthil2921 approved these changes

@kumar-himans kumar-himans kumar-himans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hariprasadt @eakraly @mohanss08 @ekambaramv @senthil2921 @kumar-himans