Update Coturn Prometheus Dependency to jelmd/libprom#1585
Open
Neboer wants to merge 1 commit intocoturn:masterfrom
Open
Update Coturn Prometheus Dependency to jelmd/libprom#1585Neboer wants to merge 1 commit intocoturn:masterfrom
Neboer wants to merge 1 commit intocoturn:masterfrom
Conversation
Collaborator
Contributor
|
I have an alternative PR in #1591 that makes the current implementation work again with updated versions of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues related to Coturn’s Prometheus dependency:
Coturn currently relies on digitalocean/prometheus-client-c, a project that has not been maintained for a long time. Issue Prometheus library dependency #1579 mentions this and suggests switching to jupp0r/prometheus-cpp. However, since
prometheus-cppis a C++ project, it is not an ideal fit for Coturn, which is written in C, making the integration more challenging.Not only is
prometheus-client-cunmaintained, but it also can no longer be successfully built against the latest version oflibmicrohttpd. This means some parts of Coturn's code are now outdated and no longer functional with newer dependencies.The jelmd/libprom project is a fork of
prometheus-client-cthat includes several updates and supports the latestlibmicrohttpd. However,libpromhas made some modifications to function names from the originalprometheus-client-c. In this PR, I’ve updated Coturn's Prometheus-related code to reflect these changes and ensure compatibility withlibprom.I have tested the changes locally, and the build was successful. The Prometheus functionality works as expected.
I kindly request the maintainers to review and consider merging this update.