Add Remote IP on log file for invalid user or connexion#1653
Open
drmanu011 wants to merge 1 commit intocoturn:masterfrom
Open
Add Remote IP on log file for invalid user or connexion#1653drmanu011 wants to merge 1 commit intocoturn:masterfrom
drmanu011 wants to merge 1 commit intocoturn:masterfrom
Conversation
Added Remote IP logging on TURN_LOG_FUNC for invalid user, needed for protect turnserver with fail2ban Are you OK?
Collaborator
|
Hi @drmanu011 2 comments:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances log messages by adding the remote IP address when logging invalid usernames or missing credentials.
- Adds remote IP logging to error messages in TURN_LOG_FUNC for invalid user credentials.
- Implements remote address extraction via addr_to_string and get_remote_addr_from_ioa_socket in two logging locations.
| if (!is_secure_string(usname, 1)) { | ||
| TURN_LOG_FUNC(TURN_LOG_LEVEL_ERROR, "session %018llu: %s: wrong username: %s\n", (unsigned long long)(ss->id), | ||
| __FUNCTION__, (char *)usname); | ||
| char saddr[129] = "\0"; |
There was a problem hiding this comment.
The code for obtaining the remote IP is duplicated. Consider extracting the IP retrieval logic into a separate helper function to improve maintainability.
| TURN_LOG_FUNC(TURN_LOG_LEVEL_ERROR, "session %018llu: %s: Cannot find credentials of user <%s>\n", | ||
| (unsigned long long)(ss->id), __FUNCTION__, (char *)usname); | ||
| char saddr[129] = "\0"; | ||
| addr_to_string(get_remote_addr_from_ioa_socket(ss->client_socket), (uint8_t *)saddr); |
There was a problem hiding this comment.
Duplicate remote IP extraction code is present here as well. Refactoring this logic into a common helper function could reduce code duplication and ease future maintenance.
Suggested change
| addr_to_string(get_remote_addr_from_ioa_socket(ss->client_socket), (uint8_t *)saddr); | |
| extract_remote_ip(ss->client_socket, saddr, sizeof(saddr)); |
Contributor
|
@drmanu011 can you review the feedback received? |
Author
|
Yes, it is easier to use a function rather than duplicating the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Remote IP logging on TURN_LOG_FUNC for invalid user, needed for protect turnserver with fail2ban
Are you OK?