Conversation
jimying
reviewed
Sep 17, 2025
jimying
left a comment
There was a problem hiding this comment.
You are missing error describe string.
should change like this:
TURN_LOG_FUNC(TURN_LOG_LEVEL_ERROR, "xxxx: %s", strerror(errno));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perror sends to standard error stream
In most current use cases there is some logging mechanism that expects the logs to appear in stdout (or other single output)
Moreover, most of the error messages printed by perror are not helpful (single words not even pointing to where the error happened and what was the context) and in a lot of places there is an additional logging macro