Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update factorization.md [Update Powersmooth Definition] #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 29, 2025

Conversation

t0wbo2t
Copy link
Contributor

@t0wbo2t t0wbo2t commented May 15, 2025

The definition of powersmooth was a bit confusing so I added a formal definition inspired by a number theory book.

The definition of powersmooth was a bit confusing so I added a formal definition inspired by a number theory book.
@adamant-pwn
Copy link
Member

Hi, thank you very much for the pull request!

I think one other issue here is that the article mistakenly applies the term "powersmooth" to $p$, while it should be applied to $p-1$ instead. Would it be okay for you to update this as well, so that it is consistent with the formal definition, and is clear enough what it refers to exactly?

On a side note, I think it's more common to put commas outside of $...$ expressions?

@t0wbo2t
Copy link
Contributor Author

t0wbo2t commented May 21, 2025

Sure, done.

Commas are now outside $...$ and definiton is for (p - 1) for consistency.
@adamant-pwn
Copy link
Member

Thanks! But what I meant is, the article currently uses an incorrect definition of powersmooth, and your initial edit was correct. And I suggested to rewrite other parts of the article to make it clear that the powersmooth number is actually $p-1$, and not $p$.

Updated materials related to powersmoothness.
Corrected some minor mistakes.
@t0wbo2t
Copy link
Contributor Author

t0wbo2t commented May 22, 2025

I have changed materials to the best of my knowledge. Please let me know if there are any errors.

Copy link
Member

@adamant-pwn adamant-pwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I added a few more change suggestions, hopefully after that situation about powersmooth numbers will be completely clarified.

@t0wbo2t t0wbo2t requested a review from adamant-pwn May 29, 2025 05:56
@adamant-pwn
Copy link
Member

Thanks!

@adamant-pwn adamant-pwn merged commit 3491526 into cp-algorithms:main May 29, 2025
github-actions bot added a commit that referenced this pull request May 29, 2025
@t0wbo2t
Copy link
Contributor Author

t0wbo2t commented May 29, 2025

Thanks to you too. I am studying from cp-algo so I am also thinking of contributing as much as possible. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants