Clarify definition of opt(i, j): choose maximum k among optimal candidates #1524
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates # Clarify definition of `opt(i, j)` to specify maximum `k` among optimal candidates ## Description This PR updates the documentation to clarify the definition of `opt(i, j)`: - Previously, it was ambiguous when multiple values of `k` achieved the optimum. - The reference explicitly states that we should take the **maximum** value of `k` among all optimal candidates. - This change makes the intended behavior explicit and avoids confusion in implementations. ## Motivation Clarifying this definition ensures consistency with the reference and prevents misinterpretation when different values of `k` yield the same optimum. ## Changes - Clarified wording in `opt(i, j)` definition. - Specified that the chosen `k` must be the maximum among all optimal candidates. > The reference is https://dl.acm.org/doi/pdf/10.1145/800141.804691, specifically, when we define $K_c$ on the left column.
|
I believe you are correct. Good catch. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify definition of
opt(i, j)to specify maximumkamong optimal candidatesDescription
This PR updates the documentation to clarify the definition of
opt(i, j):kachieved the optimum.kamong all optimal candidates.Motivation
Clarifying this definition ensures consistency with the reference and prevents misinterpretation when different values of
kyield the same optimum.Changes
opt(i, j)definition.kmust be the maximum among all optimal candidates.