Improve Convex Hull #752
Merged
Improve Convex Hull #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. That looks like a pretty good addition. |
jakobkogler
approved these changes
Oct 25, 2021
Member
|
And like you said, some parts of the explanation could use some improvements. E.g. I didn't understand why we only need to reverse the last few collinear points, and e.g. not collinear points somewhere in the middle (I eventually figured it out by looking at some examples). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the convex hull page which was a tad confusing. The title of the page was "Convex Hull construction using Graham's Scan", and the reader is presented with the Monotone Chain algorithm by Andrew's instead (and no mention of the name "Monotone Chain", although Andrew's name is subtly in there), rather than the original Graham's Scan. So in this PR we:
I think the convex hull explanation is far from ideal, but the changes seem to me like a good improvement. I'm also not sure on the convention for filenames, I used dashes in the Markdown files and underscores in source code files.