[temp] Replace 'could' and 'might' #4359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Nov 13, 2020
| one class \tcode{List<T>} for every type \tcode{T}, | ||
| each describing a linked list of elements of type \tcode{T}. | ||
| Similarly, a class template \tcode{Array} describing a contiguous, | ||
| dynamic array might be defined like this: | ||
| dynamic array can be defined like this: | ||
| \begin{codeblock} | ||
| template<class T> class Array { | ||
| T* v; |
There was a problem hiding this comment.
(Can't comment on this directly because github is terrible.) There's a bogus "may" a few lines below that should be a "can". ISO/CS noticed and called out this one in our discussion so we need to fix it.
source/templates.tex
Outdated
Comment on lines
8681
to
8682
| f(a,b); // error: \tcode{T} can be \tcode{A} or \tcode{B} | ||
| f(b,a); // error: \tcode{T} can be \tcode{A} or \tcode{B} |
There was a problem hiding this comment.
I don't think this is right; it can't be either because this is ill-formed. How about:
"error: T deduced as both A and B"
source/templates.tex
Outdated
Comment on lines
8702
to
8703
| f(g2); // error: \tcode{T} can be \tcode{char} or \tcode{int} | ||
| f(g3); // error: \tcode{U} can be \tcode{char} or \tcode{float} |
as directed by ISO/CS.
|
applied, squashed + force-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as directed by ISO/CS.
Partially addresses #4319