[class] Replace 'could' and 'might' #4361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Nov 13, 2020
source/classes.tex
Outdated
| the \grammarterm{constant-expression} is parsed as | ||
| the longest sequence of tokens | ||
| that could syntactically form a \grammarterm{constant-expression}. | ||
| that would syntactically form a \grammarterm{constant-expression}. |
There was a problem hiding this comment.
I think we can avoid the hypothetical here (and in other cases where we describe tentative parses):
Suggested change
| that would syntactically form a \grammarterm{constant-expression}. | |
| that matches the syntax of a \grammarterm{constant-expression}. |
source/classes.tex
Outdated
Comment on lines
2304
to
2308
| A | ||
| \tcode{return} | ||
| statement\iref{stmt.return} in a destructor might not directly return to the | ||
| statement\iref{stmt.return} in a destructor does not directly return to the | ||
| caller; before transferring control to the caller, the destructors for the | ||
| members and bases are called. | ||
| members and bases (if any) are called. |
There was a problem hiding this comment.
The pre-existing wording is unnecessarily verbose. I think the "does not" might be confusing in the case where there are no members or bases. How about replacing this with:
"A return statement ([stmt.return]) in a destructor calls the destructors for the members and bases (if any) before transferring control to the caller."
source/classes.tex
Outdated
| \grammarterm{conversion-function-id} | ||
| is the longest sequence of | ||
| tokens that could possibly form a \grammarterm{conversion-type-id}. | ||
| tokens that would possibly form a \grammarterm{conversion-type-id}. |
There was a problem hiding this comment.
Suggested change
| tokens that would possibly form a \grammarterm{conversion-type-id}. | |
| tokens that match the syntax of a \grammarterm{conversion-type-id}. |
There was a problem hiding this comment.
"that matches" (singular); it's referring to the sequence
fixed
as directed by ISO/CS.
|
applied, squashed, and force-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as directed by ISO/CS.
Partially addresses #4319