Added support for clang with GNU stdlib (relevant on Ubuntu 18.04) #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look at this over the weekend and try to do something about the CI failures too |
|
I updated the main branch to fix the CI issues, can you merge and run again? |
cf76c52 to
76b4f29
Compare
|
Rebased on latest main and pushed again, lets see what the CI says... |
|
Thanks! |
GerHobbelt
pushed a commit
to GerHobbelt/url
that referenced
this pull request
Mar 18, 2024
fix cpp-netlib#153, close cpp-netlib#155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using clang with GNU stdlib on older versions of stdlib where its required to pass
stdc++fsto the linker.NOTE: In the cmake check for
clang_with_gnu_stdlib, there is a generator expression checking$<NOT:$<BOOL:${WIN32}>>. This is not exactly what I would like to have there. Better would be a check for Linux, but I did not find a nice way to put that into a generator expression. MaybeUNIXwould do, but the fix is also not required on Apple.Closes #152