Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #15040 FN stlcstrConcat with compound assignment #8857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −1
Open

Fix #15040 FN stlcstrConcat with compound assignment #8857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
015da40
Update checkstl.cpp
chrchr-github Sep 15, 2026
f2a4eb8
Update teststl.cpp
chrchr-github Sep 15, 2026
5e51acf
Update checkstl.cpp
chrchr-github Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/checkstl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1986,9 +1986,11 @@ static bool isc_strCall(const Token* tok, const Library::Container* container)

static bool isc_strConcat(const Token* tok)
{
if (!tok->isBinaryOp() || !Token::simpleMatch(tok, "+"))
if (!tok->isBinaryOp() || !Token::Match(tok, "+|+="))
return false;
for (const Token* op : { tok->astOperand1(), tok->astOperand2() }) { // NOLINT(readability-use-anyofallof)
if (tok->isAssignmentOp() && astIsLHS(op))
continue;
const Token* sibling = op->astSibling();
if (!sibling->valueType())
continue;
Expand Down
6 changes: 6 additions & 0 deletions test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5161,6 +5161,12 @@ class TestStl : public TestFixture {
"}\n");
ASSERT_EQUALS("[test.cpp:2:17]: (performance) Constructing a std::string from the result of c_str() is slow and redundant. [stlcstrConstructor]\n",
errout_str());

check("void f(std::string& a, const std::string& b) {\n"
" a += b.c_str();\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2:7]: (performance) Concatenating the result of c_str() and a std::string is slow and redundant. [stlcstrConcat]\n",
errout_str());
}

void uselessCalls() {
Expand Down
Loading