simplecpp.cpp: Issue error when an explicitly included file is not found#184
Merged
danmar merged 4 commits intoDec 7, 2019
Merged
Conversation
If a file is explicitly included for example via command line option
`-include=` but can not be opened this error message is issued now.
Example:
$ ./simplecpp -include=blah.h foo.c
int main ( )
{
return 0 ;
}
foo.c:1: missing header: Can not open include file 'blah.h' that is explicitly included for all files.
Fixes cppcheck-opensource#183
versat
commented
Dec 6, 2019
Contributor
Author
|
Hmm, while this works for EDIT: Nevermind, I have found out why. Cppcheck only uses an |
`MISSING_HEADER` is only meant as an information to the user, nothing really relevant while this issue reveals a problem with the command line options that should get fixed.
danmar
approved these changes
Dec 6, 2019
danmar
left a comment
Collaborator
There was a problem hiding this comment.
looks good! Just make small tweaks!
danmar
reviewed
Dec 6, 2019
Contributor
Author
|
Sorry, I had no better idea than |
Collaborator
Not directly. Let's use this for now.. it's ok to change it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file is explicitly included for example via command line option
-include=but can not be opened this error message is issued now.Example:
$ ./simplecpp -include=blah.h foo.c
int main ( )
{
return 0 ;
}
foo.c:1: missing header: Can not open include file 'blah.h' that is explicitly included for all files.
Fixes #183