added clang-tidy CI job and fixed warnings / added CMake option "DISABLE_CPP03_SYNTAX_CHECK" / CMake cleanups#248
Conversation
60d1668 to
1f5572a
Compare
| } | ||
|
|
||
| simplecpp::TokenList::TokenList(const TokenList &other) : frontToken(nullptr), backToken(nullptr), files(other.files) | ||
| simplecpp::TokenList::TokenList(const TokenList &other) |
There was a problem hiding this comment.
I prefer to copy simplecpp in a separate PR.
There was a problem hiding this comment.
Dropped performance-move-constructor-init from this PR and will file a separate one.
26a102f to
5f48d30
Compare
|
@danmar This should be fine to merge now. |
|
I disabled |
| return (filedata.find(header) != filedata.end()) ? simplecpp::simplifyPath(header) : ""; | ||
| } | ||
|
|
||
| const std::string relativeFilename = getRelativeFileName(sourcefile, header); |
There was a problem hiding this comment.
I just wonder why you remove this const.
There was a problem hiding this comment.
That's the performance-no-automatic-move check. If a variable is returned and it is declared const it cannot be moved but is copied instead.
There was a problem hiding this comment.
so the drawback is less safety. is a const reference a better solution perhaps?
There was a problem hiding this comment.
I will drop this for now.
…sable C++03 syntax check
…istro packages - eliminates need for docker images
|
This is ready for review again. I also updated and modernized the clang-tidy job. |
The only interesting suppress warning is currently
clang-analyzer-core.NullDereferencesince it depends on very complex value flow, might be a false positive and I didn't have the time to review it.