Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adds C++20 headers so they aren't flagged as c-style headers #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

miker2
Copy link

@miker2 miker2 commented Dec 28, 2022

No description provided.

@miker2
Copy link
Author

miker2 commented Jan 9, 2023

@tkruse @mattyclarkson Any hints on why CI seems to be failing? Seems to be due to a python dependency issue and unrelated to this change.

@tkruse tkruse force-pushed the develop branch 5 times, most recently from b683f2b to 2cb090b Compare January 29, 2023 12:33
@tkruse
Copy link
Contributor

tkruse commented Jan 29, 2023

HI @miker2 , thanks for the contribution. For the CI job, it seems tox 4.0 breaks the tox-pyenv plugin: tox-dev/tox-pyenv#22. I changed to avoid tox 4.x until it gets fixed. If you rebase on master/develop branch, it should be working.

@miker2 miker2 force-pushed the add-cpp20-headers branch from 40feda4 to d141799 Compare January 29, 2023 17:07
@michael-projectx
Copy link
Contributor

@tkruse Looks like after the rebase the PR is passing. Thanks for your help.

@tkruse
Copy link
Contributor

tkruse commented Jan 30, 2023

cool, can you help me as a reviewer to check whether this list of headers is correct and complete? (E.g. do you have a reference list I could cross-check?)

@miker2
Copy link
Author

miker2 commented Jan 31, 2023

Sure, I believe I pulled the headers from this list, by searching for "c++20": https://en.cppreference.com/w/cpp/header

@tkruse tkruse merged commit a321732 into cpplint:develop Feb 13, 2023
@Bouncner
Copy link

Hi! Are there any plans to release a new tag? The last one is more than a year old and especially this PR here would be nice to be part of the lastest release.

@aaronliu0130 aaronliu0130 linked an issue Mar 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#include <span> recognized as C system header
4 participants