-
Notifications
You must be signed in to change notification settings - Fork 295
Drop Python 3.8 #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Drop Python 3.8 #334
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1a7bf1d
drop Python 3.8
aaronliu0130 255a823
of couse you'd forget
aaronliu0130 7fcfa6c
Remove annotations imports from future
aaronliu0130 57900f3
bump version
aaronliu0130 83b4e70
pylint==3.3.5
cclauss de16be4
pip install --editable ".[dev]"
cclauss 366cf4e
Apply suggestions from code review
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
drop Python 3.8
- Loading branch information
commit 1a7bf1d3850f7f882fd6c0284453f67bb9ec68e9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ authors = [ | |
{ name = "Andrew Davis", email = "[email protected]" }, | ||
{ name = "cpplint developers" }, | ||
] | ||
requires-python = ">=3.8" | ||
requires-python = ">=3.9" | ||
classifiers = [ | ||
"Development Status :: 5 - Production/Stable", | ||
"Environment :: Console", | ||
|
@@ -29,7 +29,6 @@ classifiers = [ | |
"Natural Language :: English", | ||
"Programming Language :: C++", | ||
"Programming Language :: Python :: 3 :: Only", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
|
@@ -43,7 +42,7 @@ dependencies = [ ] | |
optional-dependencies.dev = [ | ||
"mypy", | ||
"parameterized", | ||
"pylint>=2.11", | ||
"pylint>=3.3.5", | ||
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"pytest", | ||
"pytest-cov", | ||
"pytest-timeout", | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.