Some test refactoring #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aaronliu0130
commented
Apr 5, 2025
- increase default pytest timeout to 481s for debugging room
- remove duplicate boost sample for testing inspect headers
- use pytest parametrized instead of parameterized & google todo credit
- add script to update CLI test definitions
Sometimes, one hath th'need to debugst the tests. And 60s turned the good ol' debugger into Indiana Jones escapingst a rolling boulder. No more.
Before this, the exclude test did not test excluding at all and just duplicated all the errors contained in the other two .def's
This unfortunately means we must use test names like test_samples[silly-includeorder_cfirst] now. todo(unknown)s were replaced with the appropriate todo(google)s credit (we do not have the knowledge to be more specific than that)
Obviously, we should still check all the changes to the test definitions. This script just makes finding these changes easier.
cclauss
reviewed
Apr 7, 2025
| @@ -209,4 +208,4 @@ addopts = "--color=yes --cov-fail-under=90 --cov=cpplint" | |||
| python_files = [ "*test.py" ] | |||
| required_plugins = [ "pytest-cov", "pytest-timeout" ] | |||
| testpaths = [ "." ] | |||
| timeout = 60 | |||
| timeout = 481 | |||
There was a problem hiding this comment.
This seems like a massive change. Is there a particular versions of Python and/or operating system that is so slow?
There was a problem hiding this comment.
It's not that it's slow, it's that I oftentimes find myself having to debug the tests, for which 1 minute is not enough for. My average debugging time is about 5 minutes, and 418 is my favorite number.
There was a problem hiding this comment.
cclauss
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.