Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 10, 2023. It is now read-only.

Vite2 #239

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Vite2 #239

merged 4 commits into from
Mar 17, 2021

Conversation

cquiroz
Copy link
Owner

@cquiroz cquiroz commented Mar 17, 2021

This is a bit of an experiment to setup vite2. I'm quite happy with the results. we can do SmallestModule in dev mode for faster development cycles while using FewestModules in production.

Changes to assets are really fast and HMR works well.

A few drawbacks

@cquiroz cquiroz force-pushed the vite2 branch 2 times, most recently from 153a8b0 to 88abdb9 Compare March 17, 2021 18:21
@rpiaggio
Copy link
Collaborator

Nice. Looking forward to using this.

What are the demo/server.* files?

@rpiaggio
Copy link
Collaborator

Also, should all the new files in docs be checked?

@rpiaggio
Copy link
Collaborator

For now you need to manually keep the package.json file up to date

This doesn't seem to be that big of an issue. It has the same info that was previously in build.sbt right?

Copy link
Collaborator

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cquiroz
Copy link
Owner Author

cquiroz commented Mar 17, 2021

The demo/server* files are a self signed cert for the https server. Otherwise vite generates a new cert every time it starts which is annoying

Signed-off-by: Carlos Quiroz <[email protected]>
@cquiroz
Copy link
Owner Author

cquiroz commented Mar 17, 2021

Another drawback is that this doesn't let you run test that need npm modules

@cquiroz
Copy link
Owner Author

cquiroz commented Mar 17, 2021

About the package.json I already designed and compiled a sbt plugin in my mind. Now it needs to go into code :D

@cquiroz cquiroz merged commit 8b9ebbc into master Mar 17, 2021
@cquiroz cquiroz deleted the vite2 branch March 17, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants