Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore: Fix build wrt. setuptools and urllib3 #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

Chore: Fix build wrt. setuptools and urllib3 #712

merged 2 commits into from
May 6, 2025
+2 −0

Conversation

amotl
Copy link
Member

@amotl amotl commented May 6, 2025 •
edited
Loading

Problem I

ModuleNotFoundError: No module named 'setuptools.package_index'

-- https://github.com/crate/crate-python/actions/runs/14850452065/job/41692926889#step:5:97

Problem II

SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Missing Authority Key Identifier

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 6, 2025 •
edited
Loading

Walkthrough

Two new version constraints were added to the requirements.txt file: setuptools must be less than 80.3 and urllib3 must be less than 2.4. Existing dependencies remained unchanged.

Changes

File Change Summary
requirements.txt Added version constraints: setuptools <80.3 and urllib3 <2.4; existing dependencies unchanged.

Poem

A hop through the garden of code today,
Setuptools bounded, in a versioned way.
Urllib3 joins with limits tight,
Keeping dependencies just right.
With every constraint, our project grows neat—
Hopping along, we never miss a beat! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e14b501 and bb93af5.

📒 Files selected for processing (1)
  • requirements.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • requirements.txt
⏰ Context from checks skipped due to timeout of 90000ms (12)
  • GitHub Check: Python: 3.13 on macos-latest
  • GitHub Check: Python: 3.12 on macos-latest
  • GitHub Check: Python: 3.11 on macos-latest
  • GitHub Check: Python: 3.13 on ubuntu-22.04
  • GitHub Check: Python: 3.12 on ubuntu-22.04
  • GitHub Check: Python: 3.11 on ubuntu-22.04
  • GitHub Check: Python: 3.10 on ubuntu-22.04
  • GitHub Check: Python: 3.9 on ubuntu-22.04
  • GitHub Check: Python: 3.8 on ubuntu-22.04
  • GitHub Check: Analyze Python code (python, 3.11)
  • GitHub Check: Run link checker
  • GitHub Check: Python: 3.7 on ubuntu-22.04

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 6, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
requirements.txt (1)

1-1: Consider adding a lower bound to the setuptools constraint
The new <80.3 cap prevents the ModuleNotFoundError caused by removal of setuptools.package_index in 80.3+, but without a minimum version you may end up with very old releases that lack other fixes. It’s recommended to pin a known-good lower bound (e.g., setuptools>=58.0.4,<80.3).

Would you like help determining and applying the lowest compatible setuptools version?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ab391c and e14b501.

📒 Files selected for processing (1)
  • requirements.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Python: 3.13 on macos-latest
  • GitHub Check: Python: 3.12 on macos-latest
  • GitHub Check: Python: 3.11 on macos-latest
  • GitHub Check: Python: 3.13 on ubuntu-22.04
  • GitHub Check: Python: 3.12 on ubuntu-22.04
  • GitHub Check: Python: 3.11 on ubuntu-22.04
  • GitHub Check: Python: 3.10 on ubuntu-22.04
  • GitHub Check: Python: 3.9 on ubuntu-22.04
  • GitHub Check: Python: 3.8 on ubuntu-22.04
  • GitHub Check: Run link checker
  • GitHub Check: Python: 3.7 on ubuntu-22.04

@amotl amotl changed the title Chore: Fix build wrt. setuptools Chore: Fix build wrt. setuptools and urllib3 May 6, 2025
@amotl amotl marked this pull request as ready for review May 6, 2025 22:25
@amotl amotl merged commit d32b74a into main May 6, 2025
18 of 19 checks passed
@amotl amotl deleted the fix-build branch May 6, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amotl