Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add build from config support (craft command) #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add build from config support (craft command) #713

wants to merge 5 commits into from

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Fix #702

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added new feature New feature or request kind/framework Issues related to CLI app framework labels Apr 24, 2025
@crazywhalecc crazywhalecc requested a review from henderkes April 24, 2025 06:19
@crazywhalecc crazywhalecc self-assigned this Apr 24, 2025
henderkes
henderkes reviewed Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sadly not familiar with craft so I can't give an accurate review yet. If you don't mind waiting, I will have time on the weekend to test and give a more thought-through review.

@henderkes
Copy link
Collaborator

Seems all good so far, except that for some reason I'm running into 60 second timeouts when running bin/spc craft. I doubt that's related to this PR though.

@crazywhalecc
Copy link
Owner Author

Seems all good so far, except that for some reason I'm running into 60 second timeouts when running bin/spc craft. I doubt that's related to this PR though.

@henderkes I introduced symfony/process to call subcommand,but in theory subcommands should not cause unexpected timeouts.

Either that or having to re-download php-src every time is causing this problem.

@henderkes
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henderkes henderkes henderkes left review comments

Assignees

@crazywhalecc crazywhalecc

Labels
kind/framework Issues related to CLI app framework new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better build UX
2 participants
@crazywhalecc @henderkes