Fix leveled layout #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I've fixed the the tests to check for both X and Y axis rather than just the X axis which should make it much more specific what the layout should be doing. My implementation entirely fails these (passes about 25%) so... thats great :( Also made the tests test an interface so it should be easier to reuse the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff of LeveledLayout.cs looks horrific. I suggest just looking at the new version as I did something a bit different.
I noticed a couple of issues with some of the layout unit tests which I've fixed:
ConvergenceDelayedLayoutwas checking the wrong entries in levels 1 and 2 (branch 2 should be in level 2).BackPropagationSkipLayoutandBackPropagationSkipLayout2were asserting there are 4 levels even though it later checked the content of 5 levels (5 is correct).