Wire up on_tool_call when using acts_as_chat rails integration #318
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 87.49% 87.44% -0.05%
==========================================
Files 88 88
Lines 3422 3425 +3
Branches 717 717
==========================================
+ Hits 2994 2995 +1
- Misses 428 430 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpaulshippy
pushed a commit
to tpaulshippy/ruby_llm
that referenced
this pull request
Aug 3, 2025
…#318) ## What this does An `on_tool_call` callback was added in `1.4.0` via crmne#299, but it doens't work with a model using the rails integration via `acts_as_chat`. This PR wires up the missing method so it works with the integration. ## Type of change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation - [ ] Performance improvement ## Scope check - [x] I read the [Contributing Guide](https://github.com/crmne/ruby_llm/blob/main/CONTRIBUTING.md) - [x] This aligns with RubyLLM's focus on **LLM communication** - [x] This isn't application-specific logic that belongs in user code - [x] This benefits most users, not just my specific use case ## Quality check - [ ] ~I ran `overcommit --install` and all hooks pass~ - When I tried to commit the hooks generated a bunch of changes to `models.json` and `aliases.json` and broke a bunch of the specs, so I removed the hooks and ran specs and rubocop manually - [x] I tested my changes thoroughly - [x] I updated documentation if needed - No need - [x] I didn't modify auto-generated files manually (`models.json`, `aliases.json`) ## API changes - [ ] Breaking change - [ ] New public methods/classes - [ ] Changed method signatures - [x] No API changes ## Related issues <!-- Link issues: "Fixes crmne#123" or "Related to crmne#123" -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
An
on_tool_callcallback was added in1.4.0via #299, but it doens't work with a model using the rails integration viaacts_as_chat.This PR wires up the missing method so it works with the integration.
Type of change
Scope check
Quality check
I ranovercommit --installand all hooks passmodels.jsonandaliases.jsonand broke a bunch of the specs, so I removed the hooks and ran specs and rubocop manuallymodels.json,aliases.json)API changes
Related issues