Update which OpenAI models are considered "reasoning" #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 87.50% 86.83% -0.67%
==========================================
Files 88 88
Lines 3457 3457
Branches 720 709 -11
==========================================
- Hits 3025 3002 -23
- Misses 432 455 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
OpenAI reasoning models are not limited to
o1, as it is defined in the library now. Reading Reasoning models, it's the entireo-seriesthat's considered a reasoning model.I went down this rabbit hole because I noticed that GPT-5 was also listed as a reasoning model. That lead me to Azure OpenAI's documentation which provides a full list of reasoning models provided by OpenAI. I've updated the regex here to identify all of these models as "reasoning capable." (I wasn't familiar with
codex-mini, but it's a derivative of the o-series.)Type of change
Scope check
Quality check
overcommit --installand all hooks passmodels.json,aliases.json)API changes
Related issues