Fix Gemini schema conversion #355
Conversation
| result[:format] = schema[:format] if schema[:format] | ||
| result[:nullable] = schema[:nullable] if schema.key?(:nullable) | ||
| result | ||
| when 'number' | ||
| result = { type: 'NUMBER' } | ||
| result[:description] = schema[:description] if schema[:description] | ||
| result[:format] = schema[:format] if schema[:format] | ||
| result[:nullable] = schema[:nullable] if schema.key?(:nullable) | ||
| result | ||
| when 'integer' | ||
| result = { type: 'INTEGER' } | ||
| result[:description] = schema[:description] if schema[:description] | ||
| result[:format] = schema[:format] if schema[:format] | ||
| result[:nullable] = schema[:nullable] if schema.key?(:nullable) |
There was a problem hiding this comment.
I can dry this up if you want, but I decided to keep it all in the same method unless asked otherwise. I thought it best to keep it all in the same method for now.
8c7f0bb to
2418b47
Compare
|
@crmne - I saw the Rubocop failures. Initially, the overcommit hooks didn't run. I must not have had it set up. That is fixed now. I forced-pushed up a change to satisfy Rubocop. |
2418b47 to
df2c50e
Compare
- preserve descriptions, - distinguish integer/number types
df2c50e to
519a10c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 87.82% 87.85% +0.03%
==========================================
Files 88 88
Lines 3483 3500 +17
Branches 719 733 +14
==========================================
+ Hits 3059 3075 +16
- Misses 424 425 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @BrianBorge I actually wanted the code to be a little nicer and add tests, so I went ahead and did it myself so we can release this ASAP. Thanks for starting the PR! |
What this does
Fixes three critical bugs in the Gemini schema conversion that were causing schema information loss:
integerandnumbertypes incorrectly converted to singleNUMBERtypeenum,format,nullablewere not preservedThe fix ensures all schema information is properly converted to Gemini format, resulting in more accurate and contextually appropriate structured outputs.
Type of change
Scope check
Quality check
overcommit --installand all hooks passmodels.json,aliases.json)API changes
Related issues
Fixes #354
Before/After Examples
Description Preservation
Before: Generic responses due to ignored descriptions
After: Contextual responses using schema descriptions
Type Distinction
Before: Both integer and number became floats
After: Proper type enforcement
Attribute Preservation
After: All schema attributes now preserved:
descriptionfor all typesenumfor string constraintsformatfor validation hintsnullablefor optional fieldsTechnical Changes
Modified
convert_schema_to_geminimethod inlib/ruby_llm/providers/gemini/chat.rb:integer→INTEGER,number→NUMBERformat,nullable, etc.Testing