Thanks for catching this bug! The nil check for arguments is definitely needed.

I noticed the tests weren't run with updated VCR cassettes. For provider changes like this, you need to re-record them to ensure the fix works with real API responses:

bundle exec rake vcr:record[openai,openrouter]

This will delete the existing OpenAI and OpenRouter cassettes and re-run all tests to record fresh ones.

Could you also clarify what issue you encountered with the overcommit hooks? If there's a problem with our setup, I'd like to fix it. As an alternative, you can run bundle exec rubocop manually.

I've just updated our PR template to make the VCR requirement clearer for future contributors. Your feedback about the process being difficult is noted - if you have specific suggestions for improvements, I'm open to them.

The fix itself looks good and definitely belongs in the codebase. Once we have passing tests, we can merge this.

I sadly do not have OpenAI keys, and I assume these will be required to run those tests ?

As for the overcommit thing, I hereby rescind my comment. I was the culprit. I confused this upstream repo with my company's fork and was working from an old version of the codebase.

Using the current version works well. Please accept my sincere apologies 🙏

Apology accepted @elthariel!

I'll try the other OpenAI-based providers. Could you simply upload the updated VCRs for OpenRouter?

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.65%. Comparing base (34e8d75) to head (126d1e0).
⚠️ Report is 5 commits behind head on main.

@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files          35       35           
  Lines        1825     1825           
  Branches      492      492           
=======================================
  Hits         1545     1545           
  Misses        280      280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.