Fix namespaced model table names in upgrade generator #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade generator was using .tableize which produces invalid table
names for namespaced models (e.g., 'assistant/chats' instead of
'assistant_chats'). This fix uses .underscore.pluralize.tr('/', '_')
to properly convert namespaced model names to valid table names.
Fixes crmne#397
|
That was quick! Awesome! |
crmne
approved these changes
Sep 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 35 35
Lines 1889 1889
Branches 506 506
=======================================
Hits 1590 1590
Misses 299 299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crmne
pushed a commit
that referenced
this pull request
Sep 10, 2025
…399) Fixes #397 (comment) and continues work from #398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #397 where the upgrade generator produces invalid table names for namespaced models.
Problem
When using custom model names with namespaces (like
Assistant::Chat,Assistant::Message, etc.) and running the upgrade generator:The migration would generate invalid table names like
:assistant/chatsinstead of:assistant_chats.Solution
The issue was that the generator was using
.tableizewhich produces forward slashes for namespaced models. This has been fixed by using.underscore.pluralize.tr('/', '_')which properly converts namespaced model names to valid table names.Changes:
table_name_forhelper method that correctly handles namespaced modelschat_table_name,message_table_name, etc.).tableizeTesting
Tested with namespaced models to confirm:
Assistant::Chat→assistant_chats✓Assistant::Message→assistant_messages✓Assistant::ToolCall→assistant_tool_calls✓Assistant::Model→assistant_models✓Regular models continue to work as expected:
Chat→chats✓Message→messages✓Fixes #397