Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Models helps should return all supporting modalities #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2025
Merged

Models helps should return all supporting modalities #408

merged 2 commits into from
Sep 13, 2025
+25 −9

Conversation

dacamp
Copy link
Contributor

@dacamp dacamp commented Sep 12, 2025

image_models, audio_models, and embedding_models should all return models that output their modality

What this does

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
    • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
    • All tests pass: bundle exec rspec
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

Related issues

@dacamp
Copy link
Contributor Author

dacamp commented Sep 12, 2025

I noticed when calling Models.images_models I would only return imagen3 when there are infact, many other image generation models out there. I thought I'd support embedding and audio models the same way.

@crmne
Copy link
Owner

crmne commented Sep 13, 2025

Makes a lot of sense! Thanks for this.

@codecov Codecov
Copy link

codecov bot commented Sep 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.29%. Comparing base (078ef25) to head (2d261c0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files          36       36           
  Lines        1897     1897           
  Branches      493      493           
=======================================
  Hits         1599     1599           
  Misses        298      298

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crmne crmne merged commit 32b3648 into crmne:main Sep 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dacamp @crmne