fixes #946 -- return both the old and new values in Atomic::compare_exchange#1197
Merged
Conversation
…ic::compare_exchange`
Contributor
Author
|
I decided returning both made more sense than trying to just mirror the stdlib's API, because of the extreme risk existing code wouldn't notice the behavior change unless types also changed. |
Contributor
Author
|
the CI failures appear to be the ones fixed by #1196. I can rebase after that merges. |
taiki-e
approved these changes
Feb 14, 2026
Member
taiki-e
left a comment
There was a problem hiding this comment.
Thanks! It's interesting that this also revealed mistakes in our code (fetch_update) and example (compare_exchange_weak).
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #946