Refactor exercises 5 and 6 of Echidna #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Invert 5 with 6 (the CTFs order does not follow the Echidna's difficulty order) - Create a separate repo with everything configured: https://github.com/crytic/damn-vulnerable-defi-echidna - There are three branches, master, hints, solutions, to allow everyone following their own progression - Add a hints section, with templates and guidelines (ex. the multi-abi was never introduced) - Remove the complex setup due to the changes in damn vulnerable defi (everything is done in the separate repo)
Contributor
Author
|
cc @anishnaik / @ggrieco-tob Relevant PR: #143 |
Contributor
|
This looks good in general (I still need to review in detail). I think @elopez can add some basic CI tests before merging. |
elopez
reviewed
Oct 10, 2022
Member
elopez
left a comment
There was a problem hiding this comment.
CI tests added 👍 I also left a few fixes and improvements as comments below
Co-authored-by: Emilio López <[email protected]>
Co-authored-by: Emilio López <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no CI tests yet, but it should be simple to do it using the
solutionsbranch