fix esm vs. cjs typings
#1197
Closed
fix esm vs. cjs typings
#1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nope, this remains unsolvable. If you follow this route to it's end you find that there is just no way to express default exports in the correct way in both commonjs and esmodules and do this automated, not with manually crafted types. I don't think we can have correct types as long as we dual ship esm and cjs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #1031
I am not sure that I like this yet.
It adds a lot of complexity.
General approach :
esmtypings tocjs.Bundling and treeshaking the types is critical to make this work.
All types for a given plugin need to be in a known place and shape to do the string find/replace.
This obviously is very brittle and depends on a bunch more 3rd party software.