Hi @ameclement ,

Thanks a lot for opening this draft PR !
So could you please describe here the aim of the additional code, describe the current issues you encounter and where we/I could help, and grant me access to your fork, such that I can start helping by committing and pushing code directly in this PR ? Thanks !

Hi @jlenain ,

Thank you for your help!
I just commited the additional code on the tools_components.py code. The issue in the tools was mainly that the output only contained a slice, instead of all the slices of the run, making it difficult for me to plot, even with respect to time. I discussed with Pablo to temporarily define the containers as such:

charges_containers = [c for c in ChargesContainers.from_hdf5(path)]
and loop for all the output containers, thus appending my slices. This is temporary, since a loop is not always the best choice, but I haven't found one yet.

I also defined a source to choose between the event_type possibilities, as was previously done for the DeadTimeTestTool. That way, for the TimingResolutionTool, I was able to look at flatfield events. Also in the TimingResolutionTool, I widened the filter window, since in the original code, the ToM was considered above 20 ns, and the FF events for the run 7142 have a ToM at 16 ns 😄.

the last main issue is, that the merged containers (for the PedestalEstimationTool) might not be in the chronological order. I tried to run my script only for the pedestal tool, in order to plot with respect to temperature, only to find out the slices were not sorted in time. I used the np.sort() command for now, but I wanted to know if there was a better solution for the ChargesContainer slices, or if i also need to collect the ucts_timestamps and sort out the data with respect to time.

Sorry, it is a bit long, but I described everything in my code the best I could (I will also commit Vincent's scripts), and you might be able to access my fork now!

To finish, this script is pretty long, and will not be time efficient as it loops the events 5 times for the same container, so I am actively writing a tool that assembles all for one events loop, but since the issues remain the same anyway, I wanted to commit the longer code first so we can discuss. I will work on my plotting format for the rest of the data in the meantime.

Thank you!